You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed changes (including videos or screenshots)
This PR removes the use of MongoDB Change Streams on instance-status package. The removal of Change Stream items is part of an initiative started earlier this year, but resources related to instance-status were still pending.
instance-status is responsible for ensuring the connection and heartbeat between instances in a multi-instance monolithic Rocket.Chat deployment.
Since the Moleculer framework is already in use, we moved the lifecycle management of connections to it, such as node initialization, listing, etc.
As a result, it is no longer necessary to ping MongoDB and wait for a Change Stream notification to interpret a given node as valid.
The same timeout and heartbeat interval rules have been added to Moleculer:
To validate these changes, you will need to run a multi-instance monolithic Rocket.Chat deployment.
Navigate to the apps/meteor directory and run the following command to start the first instance:
cd apps/meteor
TEST_MODE=true CI=true DISABLE_DB_WATCHERS=true meteor
Navigate to the build directory and execute the following:
cd ./apps/meteor/.meteor/local/build
cd .. &&cd build && MONGO_URL=mongodb://localhost:3001/meteor INSTANCE_IP=localhost ROOT_URL=http://localhost:3000 PORT=3030 TEST_MODE=true DB_WATCHERS_DISABLED=true node main.js
This setup runs multi-instance communication using the TCP transporter. If you prefer to use NATS, you’ll need to include the NATS_TRANSPORTER environment variable. However, the changes primarily affect TCP connections.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR removes the use of MongoDB Change Streams on
instance-statuspackage. The removal of Change Stream items is part of an initiative started earlier this year, but resources related toinstance-statuswere still pending.instance-statusis responsible for ensuring the connection and heartbeat between instances in a multi-instance monolithic Rocket.Chat deployment.Since the Moleculer framework is already in use, we moved the lifecycle management of connections to it, such as node initialization, listing, etc.
As a result, it is no longer necessary to ping MongoDB and wait for a Change Stream notification to interpret a given node as valid.
The same timeout and heartbeat interval rules have been added to Moleculer:
process.env.MULTIPLE_INSTANCES_PING_INTERVAL || 10process.env.MULTIPLE_INSTANCES_EXPIRE || Math.ceil((defaultPingInterval * 3) / 60) * 60Issue(s)
Steps to test or reproduce
To validate these changes, you will need to run a multi-instance monolithic Rocket.Chat deployment.
Navigate to the
apps/meteordirectory and run the following command to start the first instance:cd apps/meteor TEST_MODE=true CI=true DISABLE_DB_WATCHERS=true meteorNavigate to the build directory and execute the following:
This setup runs multi-instance communication using the TCP transporter. If you prefer to use NATS, you’ll need to include the NATS_TRANSPORTER environment variable. However, the changes primarily affect TCP connections.
Further comments